[v3.8.6] Optimize code size for webgl-device.ts #18207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumganhar
commented
Jan 17, 2025
| @@ -110,7 +128,6 @@ export class WebGLDevice extends Device { | |||
| private _context: WebGLRenderingContext | null = null; | |||
| private _bindingMappings: IWebGLBindingMapping | null = null; | |||
|
|
|||
| /** @mangle */ | |||
There was a problem hiding this comment.
WebGLDevice is mangled, so all properties in it will be mangled, so it isn't need here.
|
@cocos-robot run test cases |
👍 Package size ⤵ -205 bytes, old: 5236578, new: 5236373Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -44877,16 +44877,14 @@
get nullTexCube(): __private._cocos_gfx_webgl_webgl_texture__WebGLTexture;
get textureExclusive(): boolean[];
get bindingMappings(): __private._cocos_gfx_webgl_webgl_gpu_objects__IWebGLBindingMapping;
get blitManager(): __private._cocos_gfx_webgl_webgl_gpu_objects__IWebGLBlitManager;
- /** @mangle */
protected _textureExclusive: boolean[];
initialize(info: Readonly<gfx.DeviceInfo>): boolean;
destroy(): void;
flushCommands(cmdBuffs: gfx.CommandBuffer[]): void;
acquire(swapchains: gfx.Swapchain[]): void;
present(): void;
- /** @mangle */
protected initFormatFeatures(exts: __private._cocos_gfx_webgl_webgl_define__IWebGLExtensions): void;
createCommandBuffer(info: Readonly<gfx.CommandBufferInfo>): gfx.CommandBuffer;
createSwapchain(info: Readonly<gfx.SwapchainInfo>): gfx.Swapchain;
createBuffer(info: Readonly<gfx.BufferInfo> | Readonly<gfx.BufferViewInfo>): gfx.Buffer;
|
|
@dumganhar, Please check the result of
Task Details
|
|
@dumganhar, Please check the result of
Task Details |
minggo
approved these changes
Jan 17, 2025
minggo
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #18206
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: